inspector: add Target.getTargets and extract TargetManager#62487
Open
cola119 wants to merge 1 commit intonodejs:mainfrom
Open
inspector: add Target.getTargets and extract TargetManager#62487cola119 wants to merge 1 commit intonodejs:mainfrom
cola119 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
cola119
added
inspector
cola119
force-pushed
the
feature/target_getTargets
branch
from
3a98316 to
6bc600c
Compare
github-actions
bot
added
request-ci-failed
Contributor
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/23699703986 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62487 +/- ##
==========================================
- Coverage 91.55% 89.70% -1.85%
==========================================
Files 351 694 +343
Lines 147653 214035 +66382
Branches 23224 41055 +17831
==========================================
+ Hits 135179 192004 +56825
- Misses 12217 14093 +1876
- Partials 257 7938 +7681
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Target.getTargetsfor worker inspection targets and move target state/session lookup logic out of TargetAgent into a dedicated TargetManager.